In tests, yes but he's played some blinders when they've been in trouble as well (record chase against Pak in Hobart, Indian tour - could've used him recently)... In ODI's, he opened on hard decks against swinging white balls and did a not too shabby job...
I wasn't saying that he didn't play the odd one of those, just that he was not tested to do so as often as he might have been had he played for a different side or in a different era.
As for teh one day stuff, its a different game really, is it not? Some players make the transition well (Gilly was made for that openers pinch hitting role, especially with the advantage of fear that the Australian side as a whole brought to opponenets) others such as Prior do not - my theory being that he is a bit something or nothing in the format, because the majority of his attacking shots in test cricket are curtailed by a conventional five men back field and h does not work the ball around well enough to be the finisher, but does not loft his shots high enough to clear the infield reliably enough to open.
That said, the new ODI regs may possibly suit him; with two new balls, teams go more conventional at the start of the innings, and only four men back at the end means he would have one get out shot free...